Domain validation fix #233
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With problem void, planner should return empty string not containing errors if the domain file is valid and cannot contain "Solution found"as it was check before
fmrico
reviewed
Jul 21, 2022
|
|
||
| return result.find("Solution Found") != result.npos; | ||
| return result.find("error") == result.npos;//no "error" string in output from the planner -> domain valid |
There was a problem hiding this comment.
I think this will not pass cpplint because spaces around //are needed (2 before and 1 after, I think), and also the line seems too long (is it <= 100). Please check it by running colcon test
There was a problem hiding this comment.
I opened another MR for this same issue before realizing that this MR already existed. ... Sorry about that. My solution is a little different from this one, but essentially the same.
I'll leave my MR open in case you want to take a look. Feel free to decline, if you decide to go with this approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With problem void, planner should return empty string not containing errors if the domain file is valid and cannot contain "Solution found"as it was check before
Edit: close issue #232 when accepted