Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] tab pages path cannot be added into WARS #266

Closed
2 tasks done
teshoudong opened this issue Oct 18, 2022 · 4 comments
Closed
2 tasks done

[BUG] tab pages path cannot be added into WARS #266

teshoudong opened this issue Oct 18, 2022 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@teshoudong
Copy link

What happened?

Hi, I try to use the new feature tab page and i put it into the iframe, but the chrome say:

so i try to use【url】prefix to get the path, because it will add the file into 【web_accessible_resources】automatically, but get the wrong path(not the tab page path):

even though, i write【web_accessible_resources】into 【package.json】, the process will crash:

Version

Latest

What OS are you seeing the problem on?

MacOSX

What browsers are you seeing the problem on?

Chrome

Relevant log output

No response

(OPTIONAL) Contact Details

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I checked the current issues for duplicate problems.
@teshoudong teshoudong added the bug Something isn't working label Oct 18, 2022
@louisgv louisgv self-assigned this Oct 18, 2022
@louisgv
Copy link
Contributor

louisgv commented Oct 18, 2022

@teshoudong Thanks for the bug report! I will experiment with this in a bit, I thought we fixed the web_accessible_resources exist check back in #229 ;d....

@louisgv louisgv changed the title [BUG] tab pages path cannot be exposed [BUG] tab pages path cannot be added into WARS Oct 18, 2022
@louisgv
Copy link
Contributor

louisgv commented Oct 18, 2022

@teshoudong what version of Plasmo are you using? I just tried with latest and this worked:

"web_accessible_resources": [
      {
        "matches": [
          "<all_urls>"
        ],
        "resources": [
          "tabs/test.html"
        ]
      }
    ],

With a tabs/test.tsx

@louisgv louisgv closed this as completed Oct 18, 2022
@teshoudong
Copy link
Author

teshoudong commented Oct 19, 2022

My version is 0.56.0, because the lastest version 0.56.1 can not be install and report the error:
image
Actually, i find a way to solve:
image
I will try lastest version later, Thanks for help!

@louisgv
Copy link
Contributor

louisgv commented Oct 19, 2022

Hmm the 0.4.0 was released 8 days ago:

https://www.npmjs.com/package/@plasmohq/parcel-packager

But yeah try 0.57.2 - it has a couple bug fixes as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants