Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync/Update workspace takes ages on a big unreal project #89

Closed
PreyK opened this issue Nov 26, 2021 · 6 comments
Closed

Sync/Update workspace takes ages on a big unreal project #89

PreyK opened this issue Nov 26, 2021 · 6 comments
Assignees

Comments

@PreyK
Copy link

PreyK commented Nov 26, 2021

SOLVED
#89 (comment)

Hello!
Our company works on heavy industrial projects in unreal.
Our project sizes are between 30-150 Gb regularly.
When I click on Sync/Update workspace it reloads ALL the assets in the project (all 150 gb of it) even if it's not changed, not touched etc..
image
image
It looks like as per https://github.com/SRombauts/UE4PlasticPlugin/blob/da88875a28463b19f64d3731693fad4b49c40a0f/Source/PlasticSourceControl/Private/PlasticSourceControlMenu.cpp#L173
and
https://github.com/SRombauts/UE4PlasticPlugin/blob/da88875a28463b19f64d3731693fad4b49c40a0f/Source/PlasticSourceControl/Private/PlasticSourceControlMenu.cpp#L187
It explicitly reloads all the packages even when it's not needed.
Is there a practical reason it's done this way?

Couldn't this be done as getting the stuff that changed from "cm" and reloading only that?

Is this project still maintained? I know Unity just bought plastic but we'd really need something for unreal as an anternative to Perforce.
We don't want to use Gluon or Plastic GUI for this because artists and staying in unreal all the time ideally.

I'll look into this for our internal use and try to come up with something for big projects.

If this plugin is still maintained and PR-s are welcome I'm happy to make one if I get somewhere.
In the meantime if anyone looked into this before any help or insight would be greatly appreciated :D

@PreyK
Copy link
Author

PreyK commented Nov 26, 2021

Update:
It looks like this was a problem on our end.
The project contained special characters in filenames (áéű) and the plugin could not update files because it was an invalid path.
When it failed as per
https://github.com/SRombauts/UE4PlasticPlugin/blob/da88875a28463b19f64d3731693fad4b49c40a0f/Source/PlasticSourceControl/Private/PlasticSourceControlMenu.cpp#L187
It reloaded all of the packages.
Because reloading took a lot of time by the time the project reloaded the notification about failing to sync disappeared so it looked like "no error, just whole project reload"

Refactoring our filenames and paths solved it, it no longer reloads the whole project on sync/update and works without errors

@SRombauts SRombauts self-assigned this Mar 2, 2022
@SRombauts
Copy link
Owner

Thanks for the report and the analysis, it may help others!

@SRombauts SRombauts reopened this May 4, 2022
@SRombauts
Copy link
Owner

There is still a couple of underlying issue here, so I am reopening it for tracking purpose

@SRombautsU SRombautsU changed the title Sync/Update workspace takes ages on a big unreal project Sync/Update workspace takes ages and crashes on a big unreal project Jul 25, 2022
@SRombautsU
Copy link
Collaborator

The underlying issue with accents in filenames have now been fixed #18

@SRombautsU SRombautsU changed the title Sync/Update workspace takes ages and crashes on a big unreal project Sync/Update workspace takes ages on a big unreal project Jul 26, 2022
@SRombautsU SRombautsU reopened this Jul 26, 2022
@SRombautsU
Copy link
Collaborator

Actually, the fact that it reloads everything and take ages is still a ongoing issue!

@SRombauts
Copy link
Owner

Hello, this has been fixed recently, with PlasticSCM#46 and PlasticSCM#47

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants