Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove html comments on default #56

Closed
rdwz opened this issue Nov 19, 2022 · 2 comments
Closed

Remove html comments on default #56

rdwz opened this issue Nov 19, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@rdwz
Copy link

rdwz commented Nov 19, 2022

from #11

I'll take a closer look at the comments one another time. But it is set to false for now in v0.0.17
@NikolaRHristov
Copy link
Member

This results in hydration errors. It's some bug with the html-minifier-terser library #11 (comment). I might apply terser/html-minifier-terser#87

@NikolaRHristov NikolaRHristov added the enhancement New feature or request label Nov 20, 2022
@NikolaRHristov
Copy link
Member

Fixed in https://github.com/astro-community/astro-compress/releases/tag/v1.1.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rdwz @NikolaRHristov