Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of LUA_USE_{POSIX,_LINUX} macros #846

Closed
Sainan opened this issue Apr 25, 2024 · 0 comments · Fixed by #847
Closed

Get rid of LUA_USE_{POSIX,_LINUX} macros #846

Sainan opened this issue Apr 25, 2024 · 0 comments · Fixed by #847
Labels
improvement Improves existing behavior

Comments

@Sainan
Copy link
Member

Sainan commented Apr 25, 2024 •
edited
Loading

We can easily detect the platform via macros that are already provided by the compiler. Having to explicitly provide these macros is such a stupid pitfall, e.g. our PHP script builds do not set these, causing problems like failing to load C modules.
@Sainan Sainan added the improvement Improves existing behavior label Apr 25, 2024
@Sainan Sainan linked a pull request Apr 25, 2024 that will close this issue
Add platform auto-detection #847
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement Improves existing behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add platform auto-detection PlutoLang/Pluto
1 participant
@Sainan