Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix XMPP connect for new Firmware 4.15.250 #49

Closed
Bertilax opened this issue Feb 18, 2019 · 15 comments
Closed

Fix XMPP connect for new Firmware 4.15.250 #49

Bertilax opened this issue Feb 18, 2019 · 15 comments

Comments

@Bertilax
Copy link

Sice Firmware 4.15.250 XMPP is enabled again and Vers. 1.1.5 is not working any more...
Confirmed working version is 0.9.3 ;)

@foxriver76
Copy link
Member

foxriver76 commented Feb 19, 2019

Latest working XMPP version of the adapter should be 1.0.0 but I recongized, that https://www.npmjs.com/package/@harmonyhub/client broke something in v1.0.7, so current latest working version for this dep is 1.0.6, otherwise I am receiving

 [CONNECT] Could not connect to hubname: TypeError: Cannot read property 'port' of undefined

@Bertilax
Copy link
Author

I tried Version 1.0.0 but it was not working - Version 0.9.3 works fine (0.9.6 was not available for download - why ever…). I tried every version back and stopped at 0.9.3.
In the future XMPP schould be the way to go - if Logitech do not touch this feature again (so they promissed ;))

@foxriver76
Copy link
Member

foxriver76 commented Feb 19, 2019

Yes, the content of 1.0 will also work, with a pinned dependency of harmonyhub client to 1.0.6 or if this will be fixed: AirBorne04/harmonyhub#26

@foxriver76
Copy link
Member

As soon as this ( Pmant/harmonyhubws#4 ) is merged, after a reinstall of the adapter it should work again with websockets.

@nob0dy80
Copy link

nob0dy80 commented Feb 19, 2019

as long its not merged, dont forget that you have to change "Harmony_Hub" to "Harmony Hub" in your scripts/flows when using 0.9.3

@nob0dy80
Copy link

nob0dy80 commented Feb 19, 2019

Ok.. like foxriver76 said, 1.0.0 is running fine with client version 1.0.6. and the best: you dont need to change the underscores in your scripts ;)

@foxriver76
Copy link
Member

V1.0.0 nehmen und in der Package JSON bei dependencies bei @harmonyhub/Client das Zirkumflex vor der Versionsnummer entfernen. Anschließend im Verzeichnis npm i ausführen.

@nob0dy80
Copy link

ah ! ok das wäre auf jeden fall der saubere weg.. ich hab einfach 1.0.0 installiert und dann die client version mit npm install @harmonyhub/client@1.0.6 drübergebügelt :-D

@DanielWeeber
Copy link

DanielWeeber commented Feb 20, 2019

Zur Hilfe für andere, die hier lesen. Aktueller Workaround wie von @foxriver76 und @nob0dy80 erklärt wie folgt:

Instanz stoppen

cd /opt/iobroker
npm install iobroker.harmony@1.0.0 --production
cd /opt/iobroker/node_modues/iobroker.harmony
npm install @harmonyhub/client@1.0.6
cd /opt/iobroker
iobroker upload harmony

Instanz starten

@DanielWeeber
Copy link

As soon as this ( Pmant/harmonyhubws#4 ) is merged, after a reinstall of the adapter it should work again with websockets.

It is merged, but newest version does not seem to connect. No error message after "connecting".

@foxriver76
Copy link
Member

Problem is that it is merged but not published yet on npm.

@DanielWeeber
Copy link

DanielWeeber commented Feb 22, 2019

Why not force the use of the GitHub repo as long it is not published?

PR #52

@foxriver76
Copy link
Member

Both Repos are owned by Pmant and he is the only one having push access. So it doesn’t make a difference. Also I don’t like git dependencies because some people do not have git installed and more support questions will pop up.

@DanielWeeber
Copy link

DanielWeeber commented Feb 22, 2019

Okay. Then everyone (who has git) can use my fork till its published ;)

@Pmant
Copy link
Collaborator

Pmant commented Feb 22, 2019

Sorry for the delay guys, I just published both repos to npm.
This adapter will stick to the websocket method since the connection handling is better and we have less dependencies.
@foxriver76 thanks a lot for the PRs.

@Pmant Pmant closed this as completed Feb 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants