Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support import to multiple destination #495

Open
wants to merge 30 commits into
base: develop
Choose a base branch
from
Open

Conversation

bouttier
Copy link
Contributor

Databases changes:

  • add bib_destinations table and references FK
  • add bib_entities table and references FK
  • add "synthese" destination
  • add SYNTHESE/ALL/C to t_permissions_available
  • copy permissions on IMPORT/IMPORT/C to SYNTHESE/ALL/C

All backend routes are prefixed with destination.
For now, the frontend calls the route with hard-coded "synthese" destination.

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (b719991) 91.18% compared to head (690a03b) 90.61%.

❗ Current head 690a03b differs from pull request most recent head d896722. Consider uploading reports for the commit d896722 to get more accurate results

Files Patch % Lines
...kend/gn_module_import/checks/dataframe/__init__.py 87.50% 1 Missing ⚠️
backend/gn_module_import/routes/imports.py 98.61% 1 Missing ⚠️
backend/gn_module_import/routes/mappings.py 93.33% 1 Missing ⚠️
backend/gn_module_import/utils.py 96.15% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #495      +/-   ##
===========================================
- Coverage    91.18%   90.61%   -0.57%     
===========================================
  Files           18       20       +2     
  Lines         1645     1567      -78     
===========================================
- Hits          1500     1420      -80     
- Misses         145      147       +2     
Flag Coverage Δ
pytest 90.61% <98.29%> (-0.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bouttier bouttier force-pushed the feat/multidest branch 3 times, most recently from b96f661 to 690a03b Compare December 2, 2023 17:20
@jacquesfize
Copy link
Contributor

jacquesfize commented Dec 11, 2023

Ne pas oublier de passer les requêtes SQLA en style 2.0 et compatible 1.4 :)

As multiple imports are attached to the same dataset, the order is not guaranteed.
Databases changes:
  - add `bib_destinations` table and references FK
  - add `bib_entities` table and references FK
  - add "synthese" destination
  - add SYNTHESE/ALL/C to `t_permissions_available`
  - copy permissions on IMPORT/IMPORT/C to SYNTHESE/ALL/C

All backend routes are prefixed with destination.
For now, the frontend calls the route with hard-coded "synthese" destination.
The validator does not fail anymore if some geom fields are not present.
For instance, it can be used with Occhab which does not accept codes.
preview_valid_data still needs some work to make it generic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants