Fixed commit #3595 #3724
Fixed commit #3595 #3724
Conversation
| if($block->getSide(1)->getLightLevel() < 4){ | ||
| Server::getInstance()->getPluginManager()->callEvent($ev = new BlockSpreadEvent($block, $this, new Dirt())); | ||
| } | ||
| elseif($block->getSide(1)->getLightLevel() >= 9){ |
There was a problem hiding this comment.
Please follow the PocketMine code style.
There was a problem hiding this comment.
Because i haven't put elseif behind the bracket?
@PEMapModder is that all correct now?
| Server::getInstance()->getPluginManager()->callEvent($ev = new BlockSpreadEvent($block, $this, new Grass())); | ||
| if(!$ev->isCancelled()){ | ||
| $this->getLevel()->setBlock($block, $ev->getNewState()); | ||
| $block = $this->getLevel()->getBlock(new Vector3($this->x, $this->y, $this->z)); |
There was a problem hiding this comment.
The dan of 2015..
There was a problem hiding this comment.
@SOF3 no need to shout. He isn't active.
There was a problem hiding this comment.
where. is. the. FACEDESK. EMOJI. NOW.
| $x = mt_rand($this->x - 1, $this->x + 1); | ||
| $y = mt_rand($this->y - 2, $this->y + 2); | ||
| $z = mt_rand($this->z - 1, $this->z + 1); | ||
| $block = $this->getLevel()->getBlock(new Vector3($x, $y, $z)); |
There was a problem hiding this comment.
Uhm just a simple thing: You see this line but complain about the other?
There was a problem hiding this comment.
I could understand that @PEMapModder didn't realize the getBlock leak problem since @shoghicp added it, but new Vector3($this->x, $this->y, $this->z) was totally pointless...
There was a problem hiding this comment.
@shoghicp added it back in October 2014, so probably too late to blame him.
There was a problem hiding this comment.
Semms so. @dktapps seems to be on a fix
See #3595