Windows & VS 2010 compilation fixes #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll try to remove the commit regarding the cmake script from this pull request. However, the other commit is not affected, and I still think that that is a right solution to a compile issue. |
|
I guess I can not just remove one commit and keep the other, so I close this pull request. |
Closed
This was referenced May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This two commits fixes two compilation issues on Windows, and VS2010.
One is a CMAKE macro error, that comes up when testing SSE availability. I am not sure about what the exact cause, but found some earlier discussions on the mailing list, and the fix is based on that.
The other is a missing C++ template parameter, that might be okay with other compilers, but Visual C++ complains about it.