Texture mapping supports more precise camera model. #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing behaviour is the default.
| @@ -37,7 +37,6 @@ | |||
|
|
|||
| #ifndef PCL_SURFACE_IMPL_TEXTURE_MAPPING_HPP_ | |||
| #define PCL_SURFACE_IMPL_TEXTURE_MAPPING_HPP_ | |||
|
|
|||
There was a problem hiding this comment.
please don't remove unrelated lines
There was a problem hiding this comment.
reverted and push out.
On 13-11-08 07:47 AM, Jochen Sprickerhof wrote:
In surface/include/pcl/surface/impl/texture_mapping.hpp:
@@ -37,7 +37,6 @@
#ifndef PCL_SURFACE_IMPL_TEXTURE_MAPPING_HPP_
#define PCL_SURFACE_IMPL_TEXTURE_MAPPING_HPP_
please don't remove unrelated lines
—
Reply to this email directly or view it on GitHub
https://github.com/PointCloudLibrary/pcl/pull/352/files#r7523912.
rbrusu
added a commit
that referenced
this pull request
Dec 14, 2013
Texture mapping supports more precise camera model.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing texture mapping assumes a camera model with center of focus in center of camera, and equal focal length on each axis. The modification enables a more general model for applications needing greater precision. The existing behaviour continues to function as the default.