Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code accidentally casting away const-ness #3648

Merged
merged 1 commit into from
Feb 14, 2020
Merged

Fix code accidentally casting away const-ness #3648

merged 1 commit into from
Feb 14, 2020

Conversation

finostro
Copy link
Contributor

@finostro finostro commented Feb 14, 2020 •
edited by kunaltyagi
Loading

Fixes #3647

It's a short quick fix.

kunaltyagi
kunaltyagi approved these changes Feb 14, 2020
View reviewed changes
Copy link
Member

@kunaltyagi kunaltyagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge pending CI

@kunaltyagi kunaltyagi changed the title Fixed a losses const error given by clang , reported with issue #3647 Fixed code accidentally casting away const-ness Feb 14, 2020
@taketwo
Copy link
Member

taketwo commented Feb 14, 2020

Thank you!

@taketwo taketwo merged commit 643d81a into PointCloudLibrary:master Feb 14, 2020
@taketwo taketwo added changelog: fix Meta-information for changelog generation and removed changelog: exclude labels Mar 18, 2020
@taketwo taketwo changed the title Fixed code accidentally casting away const-ness Fix code accidentally casting away const-ness Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taketwo taketwo taketwo approved these changes

@kunaltyagi kunaltyagi kunaltyagi approved these changes

Assignees
No one assigned
Labels
changelog: fix Meta-information for changelog generation module: common
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clang fails with a cast "loses const" error
3 participants
@finostro @taketwo @kunaltyagi