Merge FPFHEstimationOMP into FPFHEstimation #4281
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrijitsingh99
added
changelog: deprecation
kunaltyagi
reviewed
Jul 19, 2020
| FPFHEstimationOMP (unsigned int nr_threads = 0) : nr_bins_f1_ (11), nr_bins_f2_ (11), nr_bins_f3_ (11) | ||
| { | ||
| feature_name_ = "FPFHEstimationOMP"; | ||
| PCL_DEPRECATED_HEADER(1, 13, "Use <pcl/features/fpfh.h> instead.") |
There was a problem hiding this comment.
The number here is for removal. Release in 1.12 and removal in 1.13 doesn't sound great. Make it the 1.14 at least
| output[idx].histogram[d] = std::numeric_limits<float>::quiet_NaN (); | ||
|
|
||
| output.is_dense = false; | ||
| if (input_->is_dense || isFinite ((*input_)[(*indices_)[idx]])) { |
There was a problem hiding this comment.
Please benchmark this. Should not have adverse effects, but just to be sure
|
|
||
| output.is_dense = false; | ||
| if (input_->is_dense || isFinite ((*input_)[(*indices_)[idx]])) { | ||
| if (this->searchForNeighbors( |
|
Marking this as stale due to 30 days of inactivity. Commenting or adding a new commit to the pull request will revert this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges both classes and removes code duplication
TODO: