Prevent exception in PCDReader for misformed PCD files #4566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvieth
added
needs: code review
|
Is it manually edited files, since its incomplete? Or a failure at writing a file somehow? Maybe print the index number if one wants to find it (not sure if header is a fixed line count as well) ? |
The files that are written with the "official" PCDWriter should always be correct. Yes, manual editing could create such a problem, or any kind of corruption.
I don't see an easy way to print the actual line number of the PCD file, but instead the point index is printed now. That at least gives a hint where the problem is. |
larshg
approved these changes
Jan 7, 2021
koide3
approved these changes
Feb 2, 2021
kunaltyagi
reviewed
Feb 2, 2021
kunaltyagi
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.