Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use constexpr variables if possible #5522

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

SunBlack
Copy link
Contributor

Fix MSVC warning C26814: The const variable 'variable' can be computed at compile time. Consider using constexpr.

larshg
larshg previously approved these changes Nov 21, 2022
@SunBlack
Copy link
Contributor Author

Found some more occurrences after I had not anymore the noise from #5525. Therefore refreshed the PR.

larshg
larshg previously approved these changes Nov 24, 2022
@mvieth
Copy link
Member

mvieth commented Dec 14, 2022

@SunBlack Can you resolve the conflicts, please?

…ed at compile time. Consider using constexpr."
Copy link
Member

@mvieth mvieth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mvieth mvieth added the changelog: enhancement Meta-information for changelog generation label Dec 15, 2022
@mvieth mvieth merged commit f17f6dd into PointCloudLibrary:master Dec 15, 2022
@SunBlack SunBlack deleted the fix_C26814 branch December 15, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: enhancement Meta-information for changelog generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants