Fixed getColor method for HSV to RGB conversion #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Within the method getColor for HSV colored points the following issues have been fixed: - conversion from HSV to RGB values - faulty return lines - behaviour for H values > 360 and < 0, so that the color gradient is continuous. The following things have been added: - limited s and v to [0.0,1.0], that values < 0.0 are set to 0.0 and values > 1.0 are set to 1.0.
jspricke
added a commit
that referenced
this pull request
Jun 26, 2014
Fixed getColor method for HSV to RGB conversion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within the method getColor for HSV colored points the following issues
have been fixed:
gradient is continuous.
The following things have been added:
values > 1.0 are set to 1.0.