Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the geotiff open #191

Merged
merged 5 commits into from
May 13, 2023
Merged

Fixes the geotiff open #191

merged 5 commits into from
May 13, 2023

Conversation

tpoisot
Copy link
Member

@tpoisot tpoisot commented May 13, 2023

Closes #190
Closes #192

@github-actions
Copy link
Contributor

@tpoisot tpoisot marked this pull request as ready for review May 13, 2023 20:23
@codecov-commenter
Copy link

codecov-commenter commented May 13, 2023

Codecov Report

Patch coverage: 60.00% and project coverage change: +0.09 🎉

Comparison is base (31fcb88) 53.34% compared to head (1b7c26e) 53.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #191      +/-   ##
==========================================
+ Coverage   53.34%   53.43%   +0.09%     
==========================================
  Files          59       59              
  Lines        1676     1688      +12     
==========================================
+ Hits          894      902       +8     
- Misses        782      786       +4     
Flag Coverage Δ
unittests 53.43% <60.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/io/geotiff.jl 75.89% <60.00%> (-0.48%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tpoisot tpoisot merged commit 385831f into main May 13, 2023
@tpoisot tpoisot deleted the sdt/bug/io_geotiff branch May 13, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Writing a layer is creating a file with no extension Default writer should be GTiff
2 participants