bug(sdt): writing a raster works without tweaks now

* bug(sdt): write with GTiff format

Closes #190

* test(sdt): add a test for write/read for geotiff

* test(sdt): update the tests for io

* semver(sdt): v0.0.7

* feat(sdt): remove prefixed file when writing layers

Project.toml

@@ -1,7 +1,7 @@
 name = "SpeciesDistributionToolkit"
 uuid = "72b53823-5c0b-4575-ad0e-8e97227ad13b"
 authors = ["Timothée Poisot <timothee.poisot@umontreal.ca>"]
-version = "0.0.6"
+version = "0.0.7"
 
 [deps]
 ArchGDAL = "c9ce4bd3-c3d5-55b8-8973-c0e20141b8c3"

src/io/geotiff.jl

@@ -41,9 +41,9 @@ function _read_geotiff(
     driver::String = "GTiff",
     compress::String = "LZW",
 ) where {LT <: SimpleSDMLayer}
+    @assert driver ∈ keys(ArchGDAL.listdrivers()) ||
+            throw(ArgumentError("Not a valid driver."))
 
-    @assert driver ∈ keys(ArchGDAL.listdrivers()) || throw(ArgumentError("Not a valid driver."))
-
     try
         ArchGDAL.read(file) do stuff
             wkt = ArchGDAL.importPROJ4(ArchGDAL.getproj(stuff))
@@ -143,11 +143,11 @@ function _write_geotiff(
     file::AbstractString,
     layer::SimpleSDMPredictor{T};
     nodata::T = convert(T, -9999),
-    driver::String = "COG",
-    compress="LZW"
+    driver::String = "GTiff",
+    compress = "LZW",
 ) where {T <: Number}
-
-    @assert driver ∈ keys(ArchGDAL.listdrivers()) || throw(ArgumentError("Not a valid driver."))
+    @assert driver ∈ keys(ArchGDAL.listdrivers()) ||
+            throw(ArgumentError("Not a valid driver."))
     #@assert compress ∈ keys(ArchGDAL.listcompress()) || throw(ArgumentError("Not a valid compression."))
 
     array_t = _prepare_layer_for_burnin(layer, nodata)
@@ -187,6 +187,7 @@ function _write_geotiff(
             options = ["COMPRESS=$compress"],
         )
     end
+    isfile(prefix) && rm(prefix)
     return file
 end
 
@@ -214,11 +215,10 @@ function _write_geotiff(
     layers::Vector{SimpleSDMPredictor{T}};
     nodata::T = convert(T, -9999),
     driver::String = "GTiff",
-    compress::String = "LZW"
+    compress::String = "LZW",
 ) where {T <: Number}
-
-
-    @assert driver ∈ keys(ArchGDAL.listdrivers()) || throw(ArgumentError("Not a valid driver."))
+    @assert driver ∈ keys(ArchGDAL.listdrivers()) ||
+            throw(ArgumentError("Not a valid driver."))
     # to be uncommented once ths getcompressions fcn exists
     #@assert compress ∈ keys(ArchGDAL.listcompress()) || throw(ArgumentError("Not a valid compression."))
 
@@ -262,6 +262,7 @@ function _write_geotiff(
             options = ["COMPRESS=$compress"],
         )
     end
+    isfile(prefix) && rm(prefix)
     return file
 end
 

test/01_integration_read.jl

@@ -17,4 +17,14 @@ layer2 = SpeciesDistributionToolkit._read_geotiff(f, SimpleSDMPredictor)
 @test typeof(layer2) <: SimpleSDMPredictor
 @test all(values(layer) .== values(layer2))
 
-end
+# Write the data
+f = tempname() * ".tiff" # This is important because the save function checks extensions
+SpeciesDistributionToolkit.save(f, [layer]; nodata = typemax(D))
+@test isfile(f)
+
+# Read the data
+layer2 = SimpleSDMPredictor(f)
+@test typeof(layer2) <: SimpleSDMPredictor
+@test all(values(layer) .== values(layer2))
+
+end