-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
location_area_encounter response doesn't match docs #82
Comments
Hi, I'm new to Open Source and I'd like to work on this. So, should I change the return value to an array/list or change the documentation. I'll try changing the response. |
As I understand it, the return value should not change (it should still be a URL, not an array/list). I believe the docs are incorrect and need to be fixed. The issue I have is that the URL is not in the same format as every other URL. It is only a "relative" URL, it doesn't have the base host and domain name. |
We need to change the format in the docs. I'm moving this issue over at |
Just checked, the docs were updated. Feel free to reopen if you think more info is needed. |
Looking through some of the other issues, this has been a little bit of a common thread among users, but I've found (yet another) difficulty with this data field.
The docs don't match what the API gives as a response. For example, take Butterfree.
location_area_encounters
is/api/v2/pokemon/12/encounters
(this has already been brought up in Pokemon.location_area_encounters URL is not consistent with other URLs pokeapi#270).location_area_encounters
should be an array/list oflocation_area
s, each having a name and a url.I saw from PokeAPI/pokeapi#332 that the url (instead of an array) was implemented as a temp fix, but could the docs be update to reflect this change? The other thing I'm wondering, is what is the planned future of this endpoint/data? I want to know how my code should handle the server's response. It seems like the intended behavior is ambiguous here, and I'm hoping we can get a definite answer for what's wanted and implement it everywhere, docs & all.
The text was updated successfully, but these errors were encountered: