Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Scarlet / Violet moves #783

Merged
merged 1 commit into from
Dec 3, 2022
Merged

Conversation

giginet
Copy link
Contributor

@giginet giginet commented Dec 3, 2022

I added new moves since SV.

This data is migrated from this repo.
https://github.com/Ruimusume/PMSV

I'm a native Japanese speaker, So I corrected all Japanese and English move names.

I'm working on migrating data since the 9th generation. I'll submit another PRs.

@Naramsim Naramsim merged commit 52c0566 into PokeAPI:master Dec 3, 2022
@Naramsim
Copy link
Member

Naramsim commented Dec 3, 2022

Ok, let's see

@pokeapi-machine-user
Copy link

A PokeAPI/api-data refresh has started. In 45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and you will be able to review the entire API.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

@Naramsim
Copy link
Member

Naramsim commented Dec 4, 2022

I merged #778, can you replace the 0 with 9?

@Naramsim
Copy link
Member

Naramsim commented Dec 5, 2022

it seems that target_id cannot be as well 0.

https://pokeapi.co/docs/v2#movetarget here is the definition for the target_id. and here the possible values: https://pokeapi.co/api/v2/move-target/

@giginet
Copy link
Contributor Author

giginet commented Dec 11, 2022

@Naramsim Hi. Can target_id be nullable temporarily?

I can set target_id however, we have to fill this column in hands. So it takes time.
If you want actual data, it may take time. However, I can just change it to null soon.

@giginet
Copy link
Contributor Author

giginet commented Jan 3, 2023

@Naramsim
Sorry for waiting for you. I submitted PR to fill actual target_ids. #807
Could you review this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants