Some inconsistance introduced with recent PR

[WTFKr0]

Hi,

Just trying to build a local env to test and maybe contribute to 9th gen
But have some trouble in the docker-build-db step

I work on the master branch
Some data in csv are inconsistent and foreign keys missed

Maybe it's a normal process but i think the master branch should be buildable without any changes
If i'm wrong, you can close this issue

Here a list of what i found
Hope it can be usefull

1) Move names without moves

for moveid in $(awk -F',' '{print $1}' data/v2/csv/move_names.csv | grep "^[0-9]" | sort -n | uniq); do grep "^$moveid," data/v2/csv/moves.csv >/dev/null || echo "Move $moveid is missing from data/v2/csv/moves.csv"; done
Move 827 is missing from data/v2/csv/moves.csv
Move 829 is missing from data/v2/csv/moves.csv
Move 830 is missing from data/v2/csv/moves.csv
Move 831 is missing from data/v2/csv/moves.csv
Move 832 is missing from data/v2/csv/moves.csv
Move 833 is missing from data/v2/csv/moves.csv
Move 834 is missing from data/v2/csv/moves.csv
Move 835 is missing from data/v2/csv/moves.csv
Move 836 is missing from data/v2/csv/moves.csv
Move 837 is missing from data/v2/csv/moves.csv
Move 838 is missing from data/v2/csv/moves.csv
Move 850 is missing from data/v2/csv/moves.csv

2) Missing effort in pokemon_stats

Raise an int parsing exception
513 entries / 7544

grep ",$" data/v2/csv/pokemon_stats.csv
...
1008,6,50,
1009,2,75,
1009,3,60,
1009,4,45,
1009,5,100,
1009,6,20,
1010,1,110,
1010,3,80,
1010,4,50,
1010,5,90,
1010,6,90,

3) Some moves reference the non existing type id 0

awk -F"," '{if($4=="0"){print $0}}' data/v2/csv/moves.csv
851,tera-blast,9,0,80,10,100,0,0,3,,,,,
860,population-bomb,9,0,20,10,90,0,0,2,,,,,
863,revival-blessing,9,0,0,1,,0,0,1,,,,,
867,doodle,9,0,0,10,100,0,0,1,,,,,
868,fillet-away,9,0,0,10,,0,0,1,,,,,
873,raging-bull,9,0,90,10,100,0,0,2,,,,,
875,pound,9,0,40,35,100,0,0,2,,,,,
876,pound,9,0,40,35,100,0,0,2,,,,,
880,shed-tail,9,0,0,10,,0,0,1,,,,,
882,tidy-up,9,0,0,10,,0,0,1,,,,,
887,hyper-drill,9,0,100,5,100,0,0,2,,,,,

4) Some moves reference the non existing target id 0

awk -F"," '{if($9=="0"){print $0}}' data/v2/csv/moves.csv
840,esper-wing,9,13,80,10,100,0,0,3,,,,,
841,bitter-malice,9,7,75,10,100,0,0,3,,,,,
842,shelter,9,8,0,10,,0,0,1,,,,,
843,triple-arrows,9,1,90,10,100,0,0,2,,,,,
844,infernal-parade,9,7,60,15,100,0,0,3,,,,,
845,ceaseless-edge,9,16,65,15,90,0,0,2,,,,,
846,bleakwind-storm,9,2,100,10,80,0,0,3,,,,,
847,wildbolt-storm,9,12,100,10,80,0,0,3,,,,,
848,sandsear-storm,9,4,100,10,80,0,0,3,,,,,
849,lunar-blessing,9,13,0,5,,0,0,1,,,,,
851,tera-blast,9,0,80,10,100,0,0,3,,,,,
852,silk-trap,9,6,0,10,,4,0,1,,,,,
853,axe-kick,9,1,120,10,90,0,0,2,,,,,
854,last-respects,9,7,50,10,100,0,0,2,,,,,
855,lumina-crash,9,13,80,10,100,0,0,3,,,,,
856,order-up,9,15,80,10,100,0,0,2,,,,,
857,jet-punch,9,10,60,15,100,1,0,2,,,,,
858,spicy-extract,9,11,0,15,,0,0,1,,,,,
859,spin-out,9,8,100,5,100,0,0,2,,,,,
860,population-bomb,9,0,20,10,90,0,0,2,,,,,
861,ice-spinner,9,14,80,15,100,0,0,2,,,,,
862,glaive-rush,9,15,120,5,100,0,0,2,,,,,
863,revival-blessing,9,0,0,1,,0,0,1,,,,,
864,salt-cure,9,5,40,15,100,0,0,2,,,,,
865,triple-dive,9,10,30,10,95,0,0,2,,,,,
866,mortal-spin,9,3,30,15,100,0,0,2,,,,,
867,doodle,9,0,0,10,100,0,0,1,,,,,
868,fillet-away,9,0,0,10,,0,0,1,,,,,
869,kowtow-cleave,9,16,85,10,,0,0,2,,,,,
870,flower-trick,9,11,70,10,,0,0,2,,,,,
871,torch-song,9,9,80,10,100,0,0,3,,,,,
872,aqua-step,9,10,80,10,100,0,0,2,,,,,
873,raging-bull,9,0,90,10,100,0,0,2,,,,,
874,make-it-rain,9,8,120,5,100,0,0,3,,,,,
875,pound,9,0,40,35,100,0,0,2,,,,,
876,pound,9,0,40,35,100,0,0,2,,,,,
877,ruination,9,16,1,10,90,0,0,3,,,,,
878,collision-course,9,1,100,5,100,0,0,2,,,,,
879,electro-drift,9,12,100,5,100,0,0,3,,,,,
880,shed-tail,9,0,0,10,,0,0,1,,,,,
881,chilly-reception,9,14,0,10,,0,0,1,,,,,
882,tidy-up,9,0,0,10,,0,0,1,,,,,
883,snowscape,9,14,0,10,,0,0,1,,,,,
884,pounce,9,6,50,20,100,0,0,2,,,,,
885,trailblaze,9,11,50,20,100,0,0,2,,,,,
886,chilling-water,9,10,50,20,100,0,0,3,,,,,
887,hyper-drill,9,0,100,5,100,0,0,2,,,,,
888,twin-beam,9,13,40,10,100,0,0,3,,,,,
889,rage-fist,9,7,50,10,100,0,0,2,,,,,
890,armor-cannon,9,9,120,5,100,0,0,3,,,,,
891,bitter-blade,9,9,90,10,100,0,0,2,,,,,
892,double-shock,9,12,120,5,100,0,0,2,,,,,
893,gigaton-hammer,9,8,160,5,100,0,0,2,,,,,
894,comeuppance,9,16,1,10,100,0,0,2,,,,,
895,aqua-cutter,9,10,70,20,100,0,0,2,,,,,
896,blazing-torque,9,9,80,10,100,0,0,2,,,,,
897,wicked-torque,9,16,80,10,100,0,0,2,,,,,
898,noxious-torque,9,3,100,10,100,0,0,2,,,,,
899,combat-torque,9,1,100,10,100,0,0,2,,,,,
900,magical-torque,9,17,100,10,100,0,0,2,,,,,

5) pokemonstat reference pokemon id that does not exists

for pokemonid in $(awk -F',' '{print $1}' data/v2/csv/pokemon_stats.csv | grep "^[0-9]" | sort -n | uniq); do grep "^$pokemonid," data/v2/csv/pokemon.csv >/dev/null || echo "Pokemon $pokemonid is missing from data/v2/csv/pokemon.csv"; done
Pokemon 906 is missing from data/v2/csv/pokemon.csv
Pokemon 907 is missing from data/v2/csv/pokemon.csv
Pokemon 908 is missing from data/v2/csv/pokemon.csv
Pokemon 909 is missing from data/v2/csv/pokemon.csv
Pokemon 910 is missing from data/v2/csv/pokemon.csv
Pokemon 911 is missing from data/v2/csv/pokemon.csv
Pokemon 912 is missing from data/v2/csv/pokemon.csv
...

6) same for pokemontype reference pokemon id that does not exists

for pokemonid in $(awk -F',' '{print $1}' data/v2/csv/pokemon_types.csv | grep "^[0-9]" | sort -n | uniq); do grep "^$pokemonid," data/v2/csv/pokemon.csv >/dev/null || echo "Pokemon $pokemonid is missing from data/v2/csv/pokemon.csv"; done
Pokemon 906 is missing from data/v2/csv/pokemon.csv
Pokemon 907 is missing from data/v2/csv/pokemon.csv
Pokemon 908 is missing from data/v2/csv/pokemon.csv
Pokemon 909 is missing from data/v2/csv/pokemon.csv
Pokemon 910 is missing from data/v2/csv/pokemon.csv
...

Thanx for reading !

[Naramsim]

Hi, currently the master doesn't build :(

We are waiting for #783 (comment)

Sorry for the problem. I think you can check out 884d527 if you want to build

[giginet]

3. will be fixed by Fix move types and localize #801.

I'm working on target_id. Please moment.

[giginet]

#807
I fixed all target_id on this PR. It may fix the third issue.