Optimizes supply UI #5505
Merged
Optimizes supply UI #5505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheFurryFeline
added a commit
to TheFurryFeline/CHOMPstation
that referenced
this pull request
Apr 15, 2019
On the tin from PolarisSS13/Polaris#5505 and PolarisSS13/Polaris#5558. Also re-adds access restriction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces rate of data transmission, and reduces the volume quite severely (There's a lot of supplypacks)
It'll now only load the list of packs for the current active category, instead of all of them. Pack expanding behaviour remains unchanged, because the list of packs that're expanded is stored in the supply controller and doesn't need to be passed to the UI, it'll manifest in the expand var being 1 for appropriate packs.
Tested. I didn't notice any lag when initially testing, probably due to a low load and being on the same machine as the server, so I wasn't able to spot this on my own.