Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alberta Caregiver Amount #332

Closed
wants to merge 8 commits into from

Conversation

Kenyaokun
Copy link
Contributor

First try #331

Co-authored-by: YiweiJ YiweiJ@users.noreply.github.com

Kenyaokun and others added 5 commits June 8, 2023 22:12
First try PolicyEngine#331

Co-authored-by: YiweiJ <YiweiJ@users.noreply.github.com>
Final Draft PolicyEngine#331

Co-authored-by: YiweiJ <YiweiJ@users.noreply.github.com>
Co-authored-by: 7qiwx <7qiwx@users.noreply.github.com>
@Kenyaokun
Copy link
Contributor Author

I actually run several times make format, but the Lint would not pass, not sure why it does not work @MaxGhenis @PavelMakarchuk

@MaxGhenis
Copy link
Contributor

Try pip install -U black?

@Kenyaokun
Copy link
Contributor Author

Cool, it works!

@Kenyaokun Kenyaokun marked this pull request as ready for review July 4, 2023 18:19
dependant_net_income <= p.upper_dependant_income_threshold
)

caregiver_amount = (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont we need the amount for the eligible dependent as well?

Copy link
Contributor Author

@Kenyaokun Kenyaokun Jul 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need the amount for the eligible dependants: https://www.canada.ca/en/revenue-agency/services/forms-publications/tax-packages-years/general-income-tax-benefit-package/alberta/5009-pc/information-residents-alberta.html The website mentioend that "If you and another person support the same dependant, you can split the claim for that dependant. However, the total amount of your claim and the other person's claim cannot be more than the maximum amount allowed for that dependant." I think why we should include the maxmium amount.

- bump: minor
changes:
added:
- Alberta Caregiver Amount.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Alberta Caregiver Amount.
- Alberta caregiver amount.

@@ -0,0 +1,11 @@
description: Alberta limits its Child and Family Benefit to people above this age.
values:
2023-01-01: 18
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

find 2022 values

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all yaml files

label: Alberta child and Family Benefit adult dependant age eligibility
reference:
- title: Province of Alberta - Alberta Child and Family Benefit
href: https://www.canada.ca/content/dam/cra-arc/formspubs/pbg/td1ab/td1ab-23e.pdf
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add pdf pages

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all yaml files

class live_together(Variable):
value_type = bool
entity = Person
label = "Albert Caregiver Dependant"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
label = "Albert Caregiver Dependant"
label = "Dependant living with the head of household"

from policyengine_canada.model_api import *


class live_together(Variable):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class live_together(Variable):
class cohabitating_dependant(Variable):

documentation = "Whthere your spouse's or common-law partner's dependant lives with you or not."
definition_period = YEAR
reference = "chrome-extension://efaidnbmnnnibpcajpcglclefindmkaj/https://www.canada.ca/content/dam/cra-arc/formspubs/pbg/td1ab/td1ab-23e.pdf"
defined_for = ProvinceCode.AB
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
defined_for = ProvinceCode.AB

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this to the household folder

@PavelMakarchuk
Copy link
Collaborator

Duplicate of #487

@PavelMakarchuk PavelMakarchuk marked this as a duplicate of #487 May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants