Version 5.0 #223
Merged
Version 5.0 #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Convert some Observable to Single * Fix travis for Swift 4 * Bump simulator version to 11 * Convert remaining Observables to Singles * Convert `retrieve` methods to Single and add docs Converted 3 more functions from `Observable` to `Single` and adjust documentation * Merge tests
* Removed test files * Removed architecture overload for service, characteristic and descriptor * Removed references to BluetoothManager related overhead objects * Final fixes * Fixed identifier variable on UUID * Removed comments related to RxCB layer * Fixed the unnecessary comments and fixed variables namings * Review fixes
…in write function — (#174) * Used monitoring readiness for write without response in write method
…dditional information about the cause (#175)
New testing infrastructure: - removed quick & nimble - moved to XCTests - added scripts to generate testable RxBluetoothKit classes (all testable classes have „_” prefix) - added script for generating CoreBluetooth mocks - added tests for BluetoothManager.retrievePeripherals methods with use of this architecture
* Improvements to testing infrastructure - Added peripheral delegate provider to prevent delegate stealing. - Fixed not passing central manager delegate in constructor - Code generation improvements - now delegate wrappers are also mocks, not testable classes - Added attach method for reattaching RxBluetoothKit delegates to CBPeripheral and CBCentralManager
BluetoothManager.monitorDisconnection is now sending also disconnection event when bluetooth state changed to something different than .poweredOn. FIXED ISSUES: #167
Removed all complicated code related of reusing scanPeripherals method. Now it is possible to only have one scanning at a time. ISSUES FIXED: #179
- changed `BluetoothManager` to `CentralManager` - changed monitoring method to start with `observe` rather than `monitor` - it is more reactive and consistent with android library - changed behaviour of CentralManager.observeState and Peripheral.observeConnection to not start with current state - added possibility to observing any events without specifing peripheral/characteristic/descriptor - grouped all method in code with marking - changed retrievePeripherals to synchronous methods FIXED ISSUES: #208
* Changed connecting logic to handle auto disconnecting on dispose `CentralManager.connect` method has changed to `CentralManager.establishConnection`. Now it is a more complex method that handles auto disconnecting on dispose, waiting for disconnecting, and throwing errors when there is already connected/connecting device.
#215) * Added provider for Peripheral. From now on, we will have only one Peripheral for on CBPeripheral * Added unit tests
Preparation to 5.0 release
pouljohn1
approved these changes
Mar 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge version 5.0 with master branch