Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lit-next] Fix typings to match module/main #1649

Merged
merged 2 commits into from
Mar 11, 2021
Merged

Conversation

Artur-
Copy link
Contributor

@Artur- Artur- commented Mar 4, 2021

@google-cla google-cla bot added the cla: yes label Mar 4, 2021
@Artur- Artur- changed the title Fix typings to match module/main [lit-next] Fix typings to match module/main Mar 4, 2021
@@ -93,7 +93,7 @@
"tslib": "^2.0.3",
"typescript": "^4.1.3"
},
"typings": "lit-element.d.ts",
"typings": "index.d.ts",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we even need this field anymore? I feel like TypeScript looks here by default now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html says

"Also note that if your main declaration file is named index.d.ts and lives at the root of the package (next to index.js) you do not need to mark the "types" property, though it is advisable to do so."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does seems to work also if this is deleted

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep it, but it does like like "types" is the newer field.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to 'types' and moved it next to other index files

@Artur-
Copy link
Contributor Author

Artur- commented Mar 11, 2021

Anything more needed for this?

@kevinpschaaf kevinpschaaf merged commit 9075f6d into lit:lit-next Mar 11, 2021
@kevinpschaaf
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants