This repository has been archived by the owner on May 29, 2019. It is now read-only.
Update API doc links #2571
Merged
Update API doc links #2571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
May 4, 2018
| @@ -449,7 +449,7 @@ if (ShadyCSS) { | |||
| ``` | |||
|
|
|||
| Elements using the legacy API can use the | |||
| [`getComputedStyleValue`](/3.0/docs/api/mixins/Polymer.LegacyElementMixin#method-getComputedStyleValue) | |||
| [`getComputedStyleValue`](/3.0/docs/api/legacy/legacy-element-mixin#LegacyElementMixin#method-getComputedStyleValue) | |||
There was a problem hiding this comment.
should be /3.0/docs/api/legacy/legacy-element-mixin#LegacyElementMixin-method-getComputedStyleValue?
ghost
reviewed
May 4, 2018
app/3.0/docs/devguide/observers.md
Outdated
| @@ -44,7 +44,7 @@ This allows the element to avoid running observers in the default case. | |||
|
|
|||
| Like all property effects, observers are synchronous. If the observer is likely to be invoked | |||
| frequently, consider deferring time-consuming work, like inserting or removing DOM. For example, you | |||
| can use the [`Polymer.Async`](/{{{polymer_version_dir}}}/docs/api/namespaces/Polymer.Async) module to defer work. | |||
| can use the [`Polymer.Async`](/{{{polymer_version_dir}}}/docs/api/utils/async) module to defer work. | |||
There was a problem hiding this comment.
are utils still called Polymer.Thing?
also #2557
link itself looks fine tho ¯_(ツ)_/¯
ghost
reviewed
May 4, 2018
| @@ -1395,7 +1395,7 @@ rather than being bundled in with `Polymer.Element`. For details, see | |||
|
|
|||
| In many cases you can use the native platform features (such as `setTimeout` or | |||
| `requestAnimationFrame` instead of the `async` call. Polymer 2.x also provides an optional | |||
| [`Polymer.Async`](/{{{polymer_version_dir}}}/docs/api/namespaces/Polymer.Async) module that provides | |||
| [`Polymer.Async`](/{{{polymer_version_dir}}}/docs/api/utils/async) module that provides | |||
ghost
reviewed
May 4, 2018
| @@ -1546,7 +1546,7 @@ separate, optional imports. These include: | |||
| - [`<dom-bind>` element](devguide/templates#dom-bind) | |||
| - [`<dom-if>` element](devguide/templates#dom-if) | |||
| - [`<dom-repeat>` element](devguide/templates#dom-repeat) | |||
| - [`Polymer.RenderStatus`](/{{{polymer_version_dir}}}/docs/api/namespaces/Polymer.RenderStatus) | |||
| - [`Polymer.RenderStatus`](/{{{polymer_version_dir}}}/docs/api/utils/render-status) | |||
There was a problem hiding this comment.
Oh, just realized this is the upgrade guide, which needs to be totally wiped. Will leave this one alone.
ghost
approved these changes
May 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on PolymerElements/iron-doc-viewer#184
(All of the links should basically work without it except for link to OptionalMutableData.)