Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iron-collapse is focusable (by clicking or tabbing into it), which produces a focus outline in browsers #1760

Closed
punzki opened this issue Jun 5, 2015 · 3 comments

Comments

@punzki
Copy link

punzki commented Jun 5, 2015

Illustrated by demo: https://elements.polymer-project.org/elements/iron-collapse?view=demo:demo/index.html

Clicking on the content inside core-collapse, or tabbing into it, produces an ugly "focused" outline (on Chrome, a glowing blue outline). In my opinion, this should not be the desired behavior. The element controlling the iron-collapse (e.g., a button) is the one that should be focusable, and the developer is the one that should be responsible for making sure that it is. Making the iron-collapse focusable doesn't achieve anything useful.

The hostAttributes of iron-collapse has tabindex: 0, which is causing this behavior. There's no way to remove the behavior. Even setting tabindex="-1" in the iron-collapse element makes it focusable on click (strange, because it isn't tabbable).

core-collapse in v0.5 does not have this behavior; I'd say this a regression.

P.S. I'd love for this to be my first pull request/contribution to open source on GitHub, if you devs agree with me and would let me. 😃

@andrepl
Copy link

andrepl commented Jun 6, 2015

@punzki I agree this is kind of annoying, would love to see it fixed. try submitting your PR on the iron-collapse repo instead: https://github.com/polymerelements/iron-collapse/issues

@punzki
Copy link
Author

punzki commented Jun 6, 2015

@andrepl - D'oh, of course I should've opened this issue there... will copy it over and try to submit the PR.

@kevinpschaaf
Copy link
Member

Closing, as it's been moved to PolymerElements/iron-collapse#10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants