Need consistent path behavior

[robdodson]

Original thread: https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!msg/polymer-dev/JcBQZCPamcY/OMKhLetXg-4J

If I create an element that looks like this:

<polymer-element name="x-foo">
  <template>
    <template repeat="{{link in links}}">
      <div><a href="#ok{{link}}">Ok Hash Link {{link}}</a></div>
    </template>
    <div><a href="#bad">Bad Hash Link</a></div>
  </template>
  <script>
    Polymer('x-foo', {
      links : [2,3,4]
    });
  </script>
</polymer-element>

and then import it into my project, it will treat the hrefs differently. The href's inside of the repeating template will look like this:

<a href="#ok2">
<a href="#ok3">
<a href="#ok4">

but the href outside of the repeating template will look like this:

<a href="x-foo.html#bad">Bad Hash Link</a>

[erikringsmuth]

I noticed this same issue here:
http://erikringsmuth.github.io/app-router/#/notes
erikringsmuth/app-router#10

It goes a little further than hash links. Every relative path is relative to the imported document. This makes sense for <link> and <script> tags since they're used to load dependencies. <a> tags also follow this pattern. Does this make sense for <a> tags in general?

[ebidel]

Ping? Bumping priority as we're running into it with a large 🎅 project.

My current workaround is elliot's, which is to use an expression + baseURI

<a href="{{ baseURI }}#calendar">

[devinivy]

Yes, we're hoping for a fix for use on a big project too. I think @erikringsmuth's idea of treating anchor tags differently may be the ideal approach.

[ebidel]

@azakus @sorvell can anyone take a look at this?

[ssorallen]

@sorvell, was it intentional to rewrite href for anchor elements? It doesn't seem like those should be rewritten at all.

[sorvell]

Yes, the idea is that you should always be able to link resources with paths relative to the importing document. If it's an absolute url or a # based one we should bail.

[dfreedm]

The rewriter doesn't check that the node is an anchor, it just rewrites href. The simplest fix is to ignore hash-only hrefs for rewriting.