Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading representation of JavaScript accessor ("getter") #46

Open
cdata opened this issue Jun 4, 2015 · 4 comments
Open

Misleading representation of JavaScript accessor ("getter") #46

cdata opened this issue Jun 4, 2015 · 4 comments

Comments

@cdata
Copy link
Contributor

cdata commented Jun 4, 2015

When handling documentation for the following JavaScript accessor (adapted from polymerelements/iron-ajax):

  /**
   * Succeeded is true if...
   *
   * @return {boolean}
   */
  get succeeded() {
    // ...
    return true;
  }

iron-doc-viewer renders this:

image

The documentation is misleading because it suggests that succeeded is called like a method, when it is actually accessed like a basic property.

@notwaldorf
Copy link
Contributor

@cdata winner winner bug owner dinner!

Actually /cc'ing @garlicnation to see if hydrolysis should do something better in this case.

@garlicnation
Copy link
Contributor

Hydrolysis is the problem here. I need to deal w/ ES6 getters more intelligently.

@cdata
Copy link
Contributor Author

cdata commented Jun 20, 2015

ES5 getters, actually ;)

@justinfagnani
Copy link
Contributor

This is blocked by https://github.com/Polymer/hydrolysis/issues/144 though I'm not sure if fixing that will automatically fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants