-
Notifications
You must be signed in to change notification settings - Fork 35
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add a decoder for PrimitiveTypeProto and an option to disable android…
… constraints in BUILD. (#4793)
- Loading branch information
Showing
5 changed files
with
103 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
/* | ||
* Copyright 2020 Google LLC. | ||
* | ||
* This code may only be used under the BSD style license found at | ||
* http://polymer.github.io/LICENSE.txt | ||
* | ||
* Code distributed by Google as part of this project is also subject to an additional IP rights | ||
* grant found at | ||
* http://polymer.github.io/PATENTS.txt | ||
*/ | ||
|
||
package arcs.core.data.proto | ||
|
||
import arcs.core.data.PrimitiveType | ||
|
||
/** | ||
* Converts a [PrimitiveTypeProto] protobuf instance into a native kotlin [PrimitiveType] instance. | ||
*/ | ||
fun PrimitiveTypeProto.decode(): PrimitiveType = | ||
when (this) { | ||
PrimitiveTypeProto.TEXT -> PrimitiveType.Text | ||
PrimitiveTypeProto.NUMBER -> PrimitiveType.Number | ||
PrimitiveTypeProto.BOOLEAN -> PrimitiveType.Boolean | ||
PrimitiveTypeProto.UNRECOGNIZED -> | ||
throw IllegalArgumentException("Unknown PrimitiveTypeProto value.") | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
package arcs.core.data.proto | ||
|
||
import arcs.core.data.PrimitiveType | ||
import arcs.core.testutil.assertThrows | ||
import arcs.repoutils.runfilesDir | ||
import com.google.common.truth.Truth.assertThat | ||
import com.google.protobuf.Message.Builder | ||
import com.google.protobuf.Message | ||
import com.google.protobuf.TextFormat | ||
import java.io.File | ||
import org.junit.Test | ||
import org.junit.runner.RunWith | ||
import org.junit.runners.JUnit4 | ||
|
||
@RunWith(JUnit4::class) | ||
class TypeProtoDecodersTest { | ||
@Test | ||
fun decodesPrimitiveTypes() { | ||
assertThat(PrimitiveTypeProto.TEXT.decode()).isEqualTo(PrimitiveType.Text) | ||
assertThat(PrimitiveTypeProto.BOOLEAN.decode()).isEqualTo(PrimitiveType.Boolean) | ||
assertThat(PrimitiveTypeProto.NUMBER.decode()).isEqualTo(PrimitiveType.Number) | ||
assertThrows(IllegalArgumentException::class) { | ||
PrimitiveTypeProto.UNRECOGNIZED.decode() | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters