Translate Paxel expression analysis into Claims. #6406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Visitor creates a map representing claim derivations - After visiting is done, map is folded into a list of Claims.
- Supports field access and `new` / object creation - Implemented using a stack (defined by extension functions).
- Removed fragile stack approach - Added another visitor to accumulate paths - Updated old visitor to delegate to new visitor; updated tests accordingly.
- Simplified logic by substituting a fold with an associateBy.
- Now, `Path` type alias (and all aliases built on this) refer to an AccessPath.Selector.
- a line is now < 100 columns.
- Suggestions for more ergonomic Kotlin. Co-authored-by: Gogul Balakrishnan <bgogul@google.com>
- Moving path acc into its own file - map + reduce --> flatMap
- Fixed a few syntax errors - Fixed whitespace / formatting. - Removed redundant toList().
- Using `DerivationResult` to get derivations and contexts (path lists). - Removed the path acc visitor. - Updated visitor to take Unit for a Context arg. - Renamed file in analysis.
- Analysis is an inner class of Deduction - Added Equal and Derive claims; using Derive right now. - Updated tests, all passing.
- Updating Documentation - Improving whitespace
Added copyright
Replaces List<String>.asFields().
bgogul
requested changes
Oct 27, 2020
| @@ -61,7 +61,9 @@ class InformationFlow private constructor( | |||
| private val particleClaims = graph.particleNodes.associateBy( | |||
| keySelector = { it.particle }, | |||
| valueTransform = { | |||
| it.instantiatedClaims() + (typeVariableSemantics[it.particle]?.claims ?: emptyList()) | |||
There was a problem hiding this comment.
Let us not include this change in this PR. We should do this in a separate PR so that we test the data flow analysis as well.
java/arcs/core/data/AccessPath.kt
Outdated
| @@ -42,6 +42,12 @@ data class AccessPath(val root: Root, val selectors: List<Selector> = emptyList( | |||
| selectors: List<Selector> = emptyList() | |||
| ) : this(Root.Handle(handle), selectors) | |||
|
|
|||
| /** Constructs a new [AccessPath] from another, appending new [Selector]s. */ | |||
There was a problem hiding this comment.
Pull this off to a separate PR and add some tests.
| * | ||
| * See [DependencyNode] for more information. | ||
| */ | ||
| fun RecipeGraph.Node.Particle.deduceClaims(): List<Claim> { |
There was a problem hiding this comment.
Piotr had a comment in the previous PR that one should avoid using names of features in the codebase, because they can change. According to him, nothing with the name "paxel" (besides comments) is checked in.
- AssociationNode.flatten less complex and more efficient - Several private 1-liners in ClaimDeduction.kt have been rolled into a single function - Unlinking the claim deducer to InformationFlow.kt, not ready for prime time yet - Using a built-in exception assert instead of rolling my own - cleanliness + better asserts for ClaimDeductionTest.kt
|
@alxrsngrtn Let us hold off on this PR until we resolve the where expressions. It is possible that the underlying data structures change slightly to take care of where expressions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here, I introduce a public
deduceClaimsfunction to be used in theInformationFlowmodule. This translatesDependencyNodesfound in theExpressionDependencyAnalyzerintoClaimstatements.CC: @piotrswigon @cromwellian