-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chop up GSUB subtables into their own set of files #124
Conversation
This is great! But while both GSUB and GPOS have lookup types, they're wildly different, they're not really "shared", so let's create the lookups dir inside the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's change the file paths just a little, see the comment in the "conversation" tab.
It also looks like |
src/opentype/tables/advanced/shared/subtables/lookuptypes/gsub-2.js
Outdated
Show resolved
Hide resolved
src/opentype/tables/advanced/shared/subtables/lookuptypes/gsub.js
Outdated
Show resolved
Hide resolved
Thanks for the review. Good catch on |
In preparation of #45 (comment), I set up placeholder code for GPOS as well, so we don't have that in the old format. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
Fixes #101, if this is you had this directory/naming in mind :-)