Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chop up GSUB subtables into their own set of files #124

Merged
merged 5 commits into from
Jul 15, 2021
Merged

Conversation

RoelN
Copy link
Collaborator

@RoelN RoelN commented Jul 14, 2021

Fixes #101, if this is you had this directory/naming in mind :-)

@RoelN RoelN requested a review from Pomax July 14, 2021 13:39
@Pomax
Copy link
Owner

Pomax commented Jul 14, 2021

This is great! But while both GSUB and GPOS have lookup types, they're wildly different, they're not really "shared", so let's create the lookups dir inside the advanced dir instead of under shared, with dedicated dirs for gsub and gpos:

--src
 |--opentype
 | |--advanced
 | | |--shared
 | | |--lookups
 | | | |--gsub
 | | | | |--gsub-lookup.js
 | | | | |--lookup-type-1.js
 | | | | |--lookup-type-2.js
 | | | | |--...
 | | | |--gpos
 | | | | |--gpos-lookup.js
 | | | | |--lookup-type-1.js
 | | | | |--lookup-type-2.js
 | | | |

Copy link
Owner

@Pomax Pomax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's change the file paths just a little, see the comment in the "conversation" tab.

@Pomax
Copy link
Owner

Pomax commented Jul 14, 2021

It also looks like gsub.js contains the SubstLookupRecord class required by both lookup types 5 and 6, but both modules forget to import that class.

@RoelN
Copy link
Collaborator Author

RoelN commented Jul 15, 2021

Thanks for the review. Good catch on SubstLookupRecord! All things should've been addressed with the last few commits.

@RoelN
Copy link
Collaborator Author

RoelN commented Jul 15, 2021

In preparation of #45 (comment), I set up placeholder code for GPOS as well, so we don't have that in the old format.

@RoelN RoelN requested a review from Pomax July 15, 2021 10:04
Copy link
Owner

@Pomax Pomax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@Pomax Pomax merged commit 9acb079 into master Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chop up GSUB subtables into their own set of files
2 participants