Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

posthog.identify should accept user properties #102

Closed
macobo opened this issue Oct 22, 2020 · 1 comment
Closed

posthog.identify should accept user properties #102

macobo opened this issue Oct 22, 2020 · 1 comment

Comments

@macobo
Copy link
Contributor

macobo commented Oct 22, 2020

This caused PostHog/posthog#1955, a bug in our own main codebase undetected for months 😅

All other client libraries do it! [https://github.com/PostHog/posthog/issues/1955#issuecomment-714291266]

Implementation

@mariusandra @timgl - identify currently accepts two callback arguments. These are not documented on the integrations page, not in the module.d.ts, in the main comment body nor anywhere in public github I could find.

Do you agree killing this will be okay in a minor release?
@macobo macobo assigned timgl and unassigned timgl Oct 22, 2020
macobo added a commit that referenced this issue Oct 22, 2020
@macobo
Add user properties when calling posthog.identify()
2e2912d 
Helps solve #102

Note that .capture change is currently untested - testing it requires
some further refactoring, skipped for now.
@macobo macobo mentioned this issue Oct 22, 2020
Merged
2 tasks
@macobo
Copy link
Contributor Author

macobo commented Nov 5, 2020

Shipped with v1.6.0

@macobo macobo closed this as completed Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@macobo @timgl