Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close #296: Update Webhook Docs #309

Merged
merged 3 commits into from Aug 13, 2020
Merged

Close #296: Update Webhook Docs #309

merged 3 commits into from Aug 13, 2020

Conversation

yakkomajuri
Copy link
Contributor

Close #296: Updated the screenshots and cleaned up the step-by-step tutorial for MT and Slack integrations.

@Twixes
Copy link
Contributor

Twixes commented Aug 12, 2020

Is there a way to see a preview deployment of these with GitHub?

@yakkomajuri
Copy link
Contributor Author

I mean the best way to do it would be to checkout the branch and run it locally, but I'm guessing maybe you don't have permissions on this repo? In that case the next best thing is to click the branch right below the PR title and then you can browse the files on the branch, and, given that they're Markdown, GitHub should give a reasonably good preview of what you'd see on the website.

You probably know that already though. But yeah, this repo doesn't have a test deployment env like the main repo.

@mariusandra
Copy link
Collaborator

There is a way that mostly works:

2020-08-13 10 18 11

@Twixes
Copy link
Contributor

Twixes commented Aug 13, 2020

Ah, I didn't notice "View more details"! So that's really handy

Copy link
Contributor

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of nitpicks, but looks swell overall


![image](https://user-images.githubusercontent.com/53387/78574881-ec801d00-782a-11ea-9b87-8a40e49dd912.png)

## 3. Copy URL
Copy the webhook URL into the PostHog Setup page:
## 3. Setup Webhook in Posthog
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PostHog

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it!

@@ -12,18 +12,21 @@ showTitle: true
1. The dialog window will present a unique URL that will map to the channel. Make sure that you copy and save the URL—you will need to provide it to the outside service.
1. Select the Done button. The webhook will be available in the team channel.

[See Microsoft Team's documentation for more info](https://docs.microsoft.com/en-us/microsoftteams/platform/webhooks-and-connectors/how-to/add-incoming-webhook#add-an-incoming-webhook-to-a-teams-channel)
[See the Microsoft Teams Documentation for more info](https://docs.microsoft.com/en-us/microsoftteams/platform/webhooks-and-connectors/how-to/add-incoming-webhook#add-an-incoming-webhook-to-a-teams-channel).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "documentation" could be lowercase, it's not the name of a product or anything

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason I have it as upper case is because I see it as the title of a page, you see? But yeah lowercase should be fine, fixed it!

@yakkomajuri
Copy link
Contributor Author

Oh so there is a way! Stupid of me - that's great though

@jamesefhawkins
Copy link
Contributor

LGTM

@jamesefhawkins jamesefhawkins merged commit cfb4f80 into master Aug 13, 2020
@jamesefhawkins jamesefhawkins deleted the 296-webhook-docs branch August 13, 2020 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update webhooks usage docs
4 participants