-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Survey popup UI polish (add all issues here) #20851
Comments
Howdy, I took a look at tinkering with this today, and I don't think I have enough context to move forward with fixes yet since I want to make sure I'm aligned with what the team is thinking.
Is the idea here that we want the space between the top of the survey box and the first question to be the same as the space between the last question and the "submit" button? e.g. this image ![]() instead of this image? ![]()
Is this just on the popup experience for the end user (i.e. the popup rendered by posthog-js)? Because the popup rendered in the posthog app is internationalized for the close button ![]()
I'm pretty sure Annika is asking about the popup showed to the end user, but this is a problem in the rendered survey in the posthog app too (see gif). I don't have any questions about what to do here.
I should've asked Juraj when we went through this, but, what color grey are we talking about here? @annikaschmid @jurajmajerik if y'all could weigh in on these questions whenever you have the chance, I can move forward with implementing the fixes. |
Sorry I haven't responded to your questions here @dmarticus
![]() |
Got it, I'll do 1,3, and 4 in this change. BTW I figured out the default grey specified in the config; now I just need to make sure it's used correctly. Thanks for weighing in, though! |
With the completion of the above MRs, this task is now closed. |
Emojis should be grey by default
![image](https://private-user-images.githubusercontent.com/4853149/330450160-47c285b3-31cb-44f8-b9e3-f3bbacdd608a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ2OTMzMjcsIm5iZiI6MTcyNDY5MzAyNywicGF0aCI6Ii80ODUzMTQ5LzMzMDQ1MDE2MC00N2MyODViMy0zMWNiLTQ0ZjgtYjllMy1mM2JiYWNkZDYwOGEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgyNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MjZUMTcyMzQ3WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZjFhZjhiZWFmMDg5MjAxMDJlNTE0YjhiMTU4NGMzMDAzY2FiNDk4ZjUyMDc2ZGFlYWVhOWVhMWNiN2U5MzMwMiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.bHJsyfbzZnwb1zKYA8dFtUa5XD1Bi2SRbRmg7wSyKTM)
The text was updated successfully, but these errors were encountered: