Survey popup UI polish (add all issues here)

[jurajmajerik]

If no title is set, spacing is slightly off.

is it not possible to change the close button text on this one?

Emojis should be grey by default

[dmarticus]

Howdy, I took a look at tinkering with this today, and I don't think I have enough context to move forward with fixes yet since I want to make sure I'm aligned with what the team is thinking.

1. If no title is set, spacing is slightly off.

Is the idea here that we want the space between the top of the survey box and the first question to be the same as the space between the last question and the "submit" button?

e.g. this image

instead of this image?

2. is it not possible to change the close button text on this one?

Is this just on the popup experience for the end user (i.e. the popup rendered by posthog-js)? Because the popup rendered in the posthog app is internationalized for the close button

3. Is the survey the same width as the thank you screen?

I'm pretty sure Annika is asking about the popup showed to the end user, but this is a problem in the rendered survey in the posthog app too (see gif). I don't have any questions about what to do here.

4. Emojis should be grey by default

I should've asked Juraj when we went through this, but, what color grey are we talking about here?

@annikaschmid @jurajmajerik if y'all could weigh in on these questions whenever you have the chance, I can move forward with implementing the fixes.

[jurajmajerik]

Sorry I haven't responded to your questions here @dmarticus

1. Yes sounds reasonable!
2. I assume the screenshot shows a survey translated in the browser? The problem is that the Close button currently cannot be customized. So it's more like a feature request than a UI bug.
4. Up to you :) I thought there was already some default grey specified in the config. If not, the menu grey will work fine:

[dmarticus]

@jurajmajerik

Got it, I'll do 1,3, and 4 in this change. BTW I figured out the default grey specified in the config; now I just need to make sure it's used correctly. Thanks for weighing in, though!

[dmarticus]

With the completion of the above MRs, this task is now closed.