feat(surveys): added close button text customization feature #23501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +5.2 kB (+0.49%) Total Size: 1.07 MB
|
jurajmajerik
reviewed
Jul 8, 2024
jurajmajerik
reviewed
Jul 8, 2024
jurajmajerik
approved these changes
Jul 8, 2024
Co-authored-by: Juraj Majerik <juro.majerik@gmail.com>
Co-authored-by: Juraj Majerik <juro.majerik@gmail.com>
dmarticus
deleted the
feat/customize-survey-thank-you-message-close-button-text
branch
thmsobrmlr
pushed a commit
that referenced
this pull request
Jul 9, 2024
Co-authored-by: Juraj Majerik <juro.majerik@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ships with PostHog/posthog-js#1288
Closes the last task in #20851
Changes
Before
Not customizable
After
Checklist
Manually tested it, looks solid. Low-risk (it's an optional field)/easy change, just needed to make sure that the types lined up.