Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add comprehensive Cypress tests for dashboards #1171

Merged
merged 3 commits into from
Jul 10, 2020
Merged

Add comprehensive Cypress tests for dashboards #1171

merged 3 commits into from
Jul 10, 2020

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Jul 8, 2020 •
edited
Loading

Changes

  • add tests for all functions on dashboard item
  • fix bug where you couldn't move or copy due to duplicate last_refresh attribute no creation

Checklist

  • All querysets/queries filter by Team (if applicable)
  • Backend tests (if applicable)
  • Cypress E2E tests (if applicable)

@timgl timgl temporarily deployed to posthog-1161-dashboard--cvtx5l July 8, 2020 19:06 Inactive
@mariusandra
Copy link
Collaborator

Ooh, thank you for doing this!

@timgl timgl temporarily deployed to posthog-1161-dashboard--cvtx5l July 8, 2020 19:25 Inactive
@EDsCODE
Copy link
Member Author

EDsCODE commented Jul 8, 2020

Found a bug while implementing too haha

@EDsCODE EDsCODE marked this pull request as ready for review July 8, 2020 19:27
@EDsCODE EDsCODE requested review from mariusandra and timgl July 8, 2020 19:27
@EDsCODE EDsCODE merged commit 9ffa069 into master Jul 10, 2020
@EDsCODE EDsCODE deleted the 1161-dashboard-cypress-tests branch July 10, 2020 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariusandra mariusandra Awaiting requested review from mariusandra

@timgl timgl Awaiting requested review from timgl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EDsCODE @mariusandra @timgl