-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cancel dashboard queries when changing filters #13041
Conversation
covers hitting refresh while refreshing but not changing filters while refreshing
I'm still working on this. Needs more testing (so there are still console logs and things) But this is mostly there so thought I'd for an early(ish) sense-check. |
It feels that AbortController and the KILL backend route are begging to be coupled together somehow... Perhaps we should have a |
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
covers hitting refresh while refreshing but not changing filters while refreshing
Problem
Dashboards can have expensive insight queries. users may change filters or get frustrated/distracted and navigate away. We don't cancel the queries, so ClickHouse does all of the work.
Changes
Adds insight query cancellation to dashboards
TODO
punt to a follow-up
How did you test this code?
🤷 I didn't yet 🤣