feat: cancel dashboard queries when filters change #13178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macobo
reviewed
Dec 7, 2022
| abortQuery: ({ queryId }) => { | ||
| const { currentTeamId } = values | ||
| if (values.featureFlags[FEATURE_FLAGS.CANCEL_RUNNING_QUERIES]) { | ||
| api.create(`api/projects/${currentTeamId}/insights/cancel`, { client_query_id: queryId }) |
There was a problem hiding this comment.
We don't await in the insightLogic either. I think it's OK here to be completely fire and forget.
There was a problem hiding this comment.
I think it is good hygene to always await. PTSD from untracked promises causing trouble in plugin-server land.
macobo
reviewed
Dec 7, 2022
| @@ -1210,6 +1242,12 @@ export const dashboardLogic = kea<dashboardLogicType>([ | |||
| actions.setShouldReportOnAPILoad(true) | |||
| } | |||
| }, | |||
| abortQuery: ({ queryId }) => { | |||
There was a problem hiding this comment.
TODO for future: making sure that these reach time-to-see-data dataset :)
macobo
reviewed
Dec 7, 2022
macobo
reviewed
Dec 7, 2022
| actions.setRefreshStatuses( | ||
| insights.map((item) => item.short_id), | ||
| true | ||
| ) | ||
|
|
||
| // If a query is in progress, kill that query |
There was a problem hiding this comment.
Non-blocking note: It feels like there's a missing abstraction here that would make this code a lot less unwieldy. Missing kea feature?
macobo
approved these changes
Dec 7, 2022
|
It makes sense to await when capturing to metrics so will cover that in #13182 (which hopefully can follow very quickly) |
3 tasks
This was referenced May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See #13041
We cancel queries in insight logic when filters change.
Changes
Let's cancel them on dashboards too
Implements the cancellation without refactoring (make it work -> make it right -> make it fast)
How did you test this code?