fix(ingestion): do not create or update person from $snapshot events #13048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yakkomajuri
changed the title
tiina303
approved these changes
Dec 1, 2022
| // TODO: Have the snapshot events pipeline be completely separate | ||
| // from all other events | ||
| if (event.event === '$snapshot') { | ||
| return runner.nextStep('prepareEventStep', event, personContainer) |
There was a problem hiding this comment.
this is silly, we're doing this step just to do normalizeEvent but yup agreed fastest way
There was a problem hiding this comment.
Yeah I started this PR off by setting up a runSnapshotEventPipeline, but chances are I'd just leave more WIP for others
…into snapshot-person
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to really hold myself back not to get into a big refactor.
Essentially, almost every step of the pipeline now has special handling for
$snapshotevents, which tells us that they should be a whole pipeline altogether.That requires:
onSnapshotso we don't have to pipe the events to the async handlers stepWas really about to do this but I'm definitely in no place to start another refactor now, so going the easiest route.