chore(person-overrides): send overrides to ClickHouse person_override #13999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hazzadous
reviewed
Jan 31, 2023
hazzadous
reviewed
Jan 31, 2023
plugin-server/src/utils/db/db.ts
Outdated
| version | ||
| ) VALUES ($1, $2, $3, $4, $5) | ||
| ON CONFLICT (team_id, old_person_id) | ||
| DO |
There was a problem hiding this comment.
I think we can get rid of this ON CONFLICT as it would not be valid to merge old_person_id with anything new. Does that make sense @tiina303 ?
There was a problem hiding this comment.
yup that can be part of the constraint
hazzadous
reviewed
Jan 31, 2023
tiina303
changed the title
tiina303
force-pushed
the
chore/send-merge-to-kafka-tiina
branch
from
820a201
to
1715f71
Compare
This is an example of how we can update the functional_tests to take into consider the person overrides and avoid having the implementation details bleed into the tests.
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
hazzadous
force-pushed
the
chore/send-merge-to-kafka-tiina
branch
from
1715f71
to
4707005
Compare
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
added 3 commits
February 17, 2023 11:58
added 3 commits
February 17, 2023 14:15
hazzadous
changed the base branch from
master
to
fix/add-person-consrtaint-on-override
tomasfarias
force-pushed
the
fix/add-person-consrtaint-on-override
branch
3 times, most recently
from
270ff15
to
343ba86
Compare
Base automatically changed from
fix/add-person-consrtaint-on-override
to
master
February 28, 2023 13:30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?