Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to bigints #1471

Merged
merged 2 commits into from
Aug 19, 2020
Merged

Move to bigints #1471

merged 2 commits into from
Aug 19, 2020

Conversation

timgl
Copy link
Collaborator

@timgl timgl commented Aug 19, 2020

Changes

Some users have started running into issues b/c every 15 minutes we delete all rows in this table and recreate them. This migration will fix those issues.

Checklist

  • All querysets/queries filter by Team (if this PR affects any querysets/queries)
  • Backend tests (if this PR affects the backend)
  • Cypress E2E tests (if this PR affects the front and/or backend)

@timgl timgl requested a review from ungless August 19, 2020 12:27
@timgl timgl temporarily deployed to posthog-move-to-bigints-dxthzc August 19, 2020 12:28 Inactive
@timgl timgl merged commit b85415c into master Aug 19, 2020
@timgl timgl deleted the move-to-bigints branch August 19, 2020 12:54
@Twixes
Copy link
Collaborator

Twixes commented Aug 19, 2020

How will this autoincrement? I would have thought that we should use BigAutoField if we want autoincrementation. Unless we'd rather go for random numbers, but I don't see default set. 🤔

@timgl
Copy link
Collaborator Author

timgl commented Aug 19, 2020

Huh so weirdly because id was previously an autofield it still is and everything works correctly. However I think you're right in that we should probably be explicit about it. I'll create another migration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants