fix(insights): Fall back to dataNodeLogic results #22196
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We do not make requests to
/query
endpoint from dashboards (anymore). However, only these would run async.The
dataNodeLogic
that is responsible would do it, but it gets cached results now and doesn't act even when they are null.Goal:
Changes
dataNodeLogic
doesn't yet have any results, then it loadsDANGER: This is not yet checked for the bug that caused an incident.
Somewhere here this leads to the logic aborting queries (sending
DELETE
requests) before even starting to send the first ones.Update: Found the culprit. For each insight that has
result: null
when the dashboard loads, thedataNodeLogic
already triggers, which is not what we want. Because it triggers multiple times somehow, it cancels its own queries as well, leading to theDELETE
requests.Does this work well for both Cloud and self-hosted?
n/a
How did you test this code?
tbd