Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2094 too many distinct #2480

Merged
merged 12 commits into from
Nov 25, 2020
Merged

2094 too many distinct #2480

merged 12 commits into from
Nov 25, 2020

Conversation

GalDayan
Copy link
Contributor

@GalDayan GalDayan commented Nov 24, 2020 •
edited
Loading

Changes

Closes #2094

Show All Distinct Id

Checklist

  • All querysets/queries filter by Organization, Team, and User (if this PR affects ANY querysets/queries).
  • Django backend tests (if this PR affects the backend).
  • Cypress end-to-end tests (if this PR affects the frontend).

@GalDayan GalDayan marked this pull request as draft November 24, 2020 00:24
@GalDayan GalDayan marked this pull request as ready for review November 24, 2020 17:03
timgl
timgl reviewed Nov 24, 2020
View reviewed changes
posthog/api/feature_flag.py Outdated Show resolved Hide resolved
timgl
timgl reviewed Nov 24, 2020
View reviewed changes
Copy link
Collaborator

@timgl timgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some unrelated feature flag code, otherwise looks great, thanks for picking this up!

@GalDayan
Copy link
Contributor Author

Some unrelated feature flag code, otherwise looks great, thanks for picking this up!

Great thanks. I added 2 test cases to e2e.
Lets finish it will pass and you can merge 👍

@GalDayan GalDayan requested a review from timgl November 24, 2020 23:40
@timgl timgl merged commit 000f76a into PostHog:master Nov 25, 2020
@timgl
Copy link
Collaborator

timgl commented Nov 25, 2020

Awesome thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timgl timgl Awaiting requested review from timgl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Too many distinct_ids
2 participants
@GalDayan @timgl