Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rolling retention widget #2522

Merged
merged 4 commits into from
Dec 4, 2020
Merged

Rolling retention widget #2522

merged 4 commits into from
Dec 4, 2020

Conversation

timgl
Copy link
Collaborator

@timgl timgl commented Nov 26, 2020

Changes

Previously when adding retention to the dashboard it would have a fixed date and never update. This fixes that by

  • by default not setting a selectedDate as the filter
  • adding an X button if you have selected a date so you can easily unselect it
  • add a migration to remove all selectedDate from any retention dashboard item, as I think all of those were not meant to be set.

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@timgl timgl requested a review from macobo November 26, 2020 10:39
@timgl timgl temporarily deployed to posthog-rolling-retenti-oelrhp November 26, 2020 10:41 Inactive
Copy link
Contributor

@macobo macobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, though failing test.

Not-directly-related-to-pr: I hadn't used retention in a while and the title Current date confused me until I played around with it. Maybe worth renaming this to e.g. Last date?

Good job!

@timgl timgl merged commit 3970e6a into master Dec 4, 2020
@timgl timgl deleted the rolling-retention-widget branch December 4, 2020 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants