Closes #2542 remove send event overlay and replace with warning #2544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👏👏👏 for the change! Just one problem - it doesn't play well with the new design (let's release it already?) -- it looks a bit washed out over that grey background... and too close to the white bar.
|
|
Added a bit of margin in the new design |
|
We're probably clashing with some handcrafted yellow color that should be used instead, but good enough for now! |
mariusandra
approved these changes
Nov 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Send overlay randomly broke a bunch of pages. I've also had complaints from users in Slack that they couldn't set up feature flags without first sending events which didn't make sense for their use case.
Checklist