Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ee webhook #2664

Merged
merged 3 commits into from
Dec 4, 2020
Merged

Fix ee webhook #2664

merged 3 commits into from
Dec 4, 2020

Conversation

timgl
Copy link
Collaborator

@timgl timgl commented Dec 4, 2020

Changes

IIRC, we disabled this b/c we had a user with high volume but the actual issue turned out to be something different. I feel reasonably confident turning this back on as I've gotten rid of the retry that caused messages to appear twice, and I'm doing some pre-filtering before firing an event into celery.

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@timgl timgl requested a review from EDsCODE December 4, 2020 09:52
@timgl timgl temporarily deployed to posthog-fix-webhook-ee-8zwtlqu December 4, 2020 09:54 Inactive
Copy link
Member

@EDsCODE EDsCODE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending @Twixes's comment. We'll just watch this closely again on prod because I think you're right there were confounding factors when we first removed this

@timgl timgl temporarily deployed to posthog-fix-webhook-ee-8zwtlqu December 4, 2020 15:29 Inactive
@timgl timgl merged commit adcf493 into master Dec 4, 2020
@timgl timgl deleted the fix-webhook-ee branch December 4, 2020 15:43
Twixes added a commit to PostHog/posthog-zapier that referenced this pull request Dec 4, 2020
shadow-shaman0209 pushed a commit to shadow-shaman0209/posthog-zapier that referenced this pull request Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants