Plugin unique url with different private tokens & improve privacy #3033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Managed to break some things with the last fixes, but looks good now. Ready to be reviewed! |
EDsCODE
added a commit
that referenced
this pull request
Jan 21, 2021
* master: Add handing off event ingestion to plugin server (#2898) Plugin unique url with different private tokens & improve privacy (#3033) Delete omni_person.proto (#3014) Don't install unused pandas and numpy (#3034) 2248 remove pandas numpy (#2997) Exclude health from ip block (#3027) Allow filtering by unseen recordings (#3000) Don't include materialized columns in kafka table (#3026) Standardize created at and by table columns (#2961) Add user param for clickhouse if provided (#3025) Setup logging to system.text_log in dev environment (#3024) feat: set event root logger severity using the DJANGO_LOG_LEVEL env variable (#3016) feat: allow setting Sentry environment by using the SENTRY_ENVIRONMENT env variable (#3015)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
private_tokenfrom the plugin serializer --> can't leak potential secrets to posthog users in the API responseChecklist