Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exception when using a bad selector to select actions #3067

Merged
merged 1 commit into from Jan 25, 2021
Merged

Fix exception when using a bad selector to select actions #3067

merged 1 commit into from Jan 25, 2021

Conversation

mariusandra
Copy link
Collaborator

Changes

  • Fix the toolbar crashing when trying to use an incorrect selector to find an action ([id="sign-up-cta"] > in this case)
  • Removes random console.log

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@timgl timgl temporarily deployed to posthog-toolbar-actions-vs8glm January 25, 2021 08:06 Inactive
@Twixes Twixes merged commit 88e1300 into master Jan 25, 2021
@Twixes Twixes deleted the toolbar-actions-selector-fix branch January 25, 2021 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Twixes Twixes Twixes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mariusandra @Twixes @timgl