-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move adding feature flags to event to capture endpoint #3090
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine to merge, but can you keep an eye on the endpoint stats to see if this dramatically increases the time it takes to post stuff?
This changes one thing with all events: adds a |
Also, tests are failing because of this. Note, I'd actually be in favor of making sure all events always have a |
Obvs, will watch this @timgl |
I guess we can accept missing properties here and just add an empty object in the plugin server to make life easier for plugins. |
Changes
This will save us a ton of work by moving adding feature flags to event properties earlier in the Python part of the pipeline, instead of forcing us to redo this in JS.