Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support client-side compact number formatting & instrumentation #3360

Merged
merged 6 commits into from Feb 19, 2021
Merged

Support client-side compact number formatting & instrumentation #3360

merged 6 commits into from Feb 19, 2021

Conversation

paolodamico
Copy link
Contributor

@paolodamico paolodamico commented Feb 17, 2021 •
edited

Changes

  • Following Billing page improvements #3192 & https://github.com/PostHog/posthog-production/pull/69, implements the compactNumber filter on client-side with tests. (e.g. 50383233 becomes 50.4M).
  • Introduces support for plain numeric values for previously FormattedNumber props to start the transition to client-side formatting only. A sequential PR in posthog-production will change these values to plain numbers, and a subsequent PR here will remove legacy code.
    • Related to the above, deprecation notices added.
  • Adds a bunch of properties related to cloud billing as event super-properties. This will help us understand things like: a) how is the behavior of paying vs. free users different, b) do users keep using PH after exceeding their event allocation, ...

Checklist

  • All querysets/queries filter by Organization, by Team, and by User. Not applicable
  • Django backend tests. Not applicable
  • Jest frontend tests. Not applicable
  • Cypress end-to-end tests

@paolodamico paolodamico changed the title Suppor client-side compact number formatting & instrumentation Support client-side compact number formatting & instrumentation Feb 17, 2021
@paolodamico paolodamico marked this pull request as draft February 17, 2021 02:25
@timgl timgl temporarily deployed to posthog-client-side-num-uwjisj February 17, 2021 02:27 Inactive
@timgl timgl temporarily deployed to posthog-client-side-num-uwjisj February 17, 2021 12:20 Inactive
@paolodamico paolodamico mentioned this pull request Feb 17, 2021
Merged
4 tasks
@paolodamico paolodamico marked this pull request as ready for review February 17, 2021 13:36
@timgl timgl temporarily deployed to posthog-client-side-num-uwjisj February 17, 2021 13:36 Inactive
@Twixes Twixes had a problem deploying to posthog-client-side-num-uwjisj February 17, 2021 14:06 Failure
Twixes
Twixes reviewed Feb 17, 2021
View reviewed changes
frontend/src/lib/utils.tsx Outdated Show resolved Hide resolved
@Twixes Twixes temporarily deployed to posthog-client-side-num-uwjisj February 17, 2021 14:15 Inactive
@timgl timgl temporarily deployed to posthog-client-side-num-uwjisj February 19, 2021 17:04 Inactive
@paolodamico paolodamico merged commit b25a72d into master Feb 19, 2021
@paolodamico paolodamico deleted the client-side-number-formatting branch February 19, 2021 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Twixes Twixes Twixes left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paolodamico @Twixes @timgl